[FLINK-29612] Extract changelog files out of DataFileMeta#extraFiles #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Oct 14, 2022
| changelogFiles.add(changelogWriter.result()); | ||
| } catch (Exception e) { | ||
| // exception occurs, clean up written file | ||
| writerFactory.deleteFile(fileMeta.fileName()); |
Contributor
There was a problem hiding this comment.
no need to delete file, already in newFiles
| compactChanges.addAll(collectChanges(committable.compactAfter(), FileKind.ADD)); | ||
|
|
||
| if (createEmptyCommit || !appendChanges.isEmpty()) { | ||
| List<ManifestEntry> appendMergeTree = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
No mergetree, appendDataFiles?
JingsongLi
reviewed
Oct 14, 2022
| if (fileMeta == null) { | ||
| for (String extraFile : extraFiles) { | ||
| writerFactory.deleteFile(extraFile); | ||
| Iterator<KeyValue> iterator = memTable.mergeIterator(keyComparator, mergeFunction); |
Contributor
There was a problem hiding this comment.
Writing data first will sort the data in the writer buffer, which will make the changelog different from the input order.
But it may not be a bad thing, because in #315 It is impossible to maintain the input order.
It is better to note the following sequence here.
JingsongLi
reviewed
Oct 14, 2022
| @Test | ||
| public void testStreamingChangelogCompatibility02() throws Exception { | ||
| // already contains 2 commits | ||
| CompatibilityTestUtils.unzip("compatibility/0.2-changelog-table.zip", tablePath.getPath()); |
Contributor
There was a problem hiding this comment.
rename to table-changelog-0.2.zip?
JingsongLi
reviewed
Oct 14, 2022
| newChangesListName = manifestList.write(newChangesManifests); | ||
|
|
||
| // write changelog into manifest files | ||
| changelogMetas.addAll(manifestFile.write(changelogFiles)); |
Contributor
There was a problem hiding this comment.
Can we avoid generating redundant files without changelog?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently changelog files are stored as extra files in
DataFileMeta. However for the full compaction changelog we're about to introduce, it cannot be added as extra files because their statistics might be different from the corresponding merge tree files.We need to extract changelog files out of
DataFileMeta#extraFiles.