[FLINK-29702] Add micro benchmarks module and merge tree reader/writer benchmarks #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Oct 24, 2022
| @Benchmark | ||
| public void write(KeyValueData data) throws Exception { | ||
| kv.replace(data.key, sequenceNumber++, data.kind, data.value); | ||
| writer.write(kv); |
Contributor
There was a problem hiding this comment.
It seems that there is a concurrency security problem. Maybe we should prohibit the use of multithreading in testing.
FangYongs
force-pushed
the
FLINK_29702_mergetree_reader_writer_micro_benchmarks
branch
from
1c89611 to
b5c0995
Compare
Contributor
Author
|
Hi @JingsongLi I have splited the reader/writer factory for compaction in the micro benchmarks and fix the concurrency problem, please review again, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we create
flink-table-store-micro-benchmarksmodule inflink-table-store-benchmark, and add merge tree reader/writer benchmarks:MergeTreeReaderBenchmarkwe first create a writer to write about 50*50000 records to the store, and performance the latency of scan in reader.MergeTreeWriterBenchmarkwe performance the throughput of write in merge tree with compaction