[FLINK-29840] Fix bug that old record may overwrite new record in Table Store when snapshot committing is slow #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-picked from #354)
Consider the following scenario when snapshot committing is slow:
In this scenario, records from checkpoint T may overwrite records from checkpoint T+2 because they have larger sequence numbers.
This PR fixes this bug by comparing last modified commit identifier and the latest committed identifier before closing a writer. If by comparing we found that the last modification is already committed, we can safely close the writer.