[FLINK-30033] Add primary key type validation #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Nov 16, 2022
JingsongLi
reviewed
Nov 17, 2022
...k-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java
Outdated
Show resolved
Hide resolved
...k-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
CI fails due to HiveE2E, which is a known issue and has created in https://issues.apache.org/jira/browse/FLINK-30038 |
FangYongs
force-pushed
the
FLINK_30033_primary_key_data_type_validation
branch
from
1113db2 to
90ba8ed
Compare
JingsongLi
approved these changes
Nov 18, 2022
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the table store does not verify the primary key type. Users can create primary keys on any data type. Some primary key types such as array, map, etc. are meaningless.
This PR refers to the primary key type of hive in https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-CreateTableCreate/Drop/TruncateTable , and restricts the primary key type of the table store.