Skip to content

[FLINK-31032] Supports AND push down for orc format#527

Merged
JingsongLi merged 2 commits into
apache:masterfrom
FangYongs:FLINK-31032_and_predicate_for_orc
Feb 14, 2023
Merged

[FLINK-31032] Supports AND push down for orc format#527
JingsongLi merged 2 commits into
apache:masterfrom
FangYongs:FLINK-31032_and_predicate_for_orc

Conversation

@FangYongs
Copy link
Copy Markdown
Contributor

This PR aims to supports AND push down in orc format.

@FangYongs FangYongs force-pushed the FLINK-31032_and_predicate_for_orc branch 2 times, most recently from ef79996 to d898115 Compare February 13, 2023 10:03
public static class And extends Predicate {
private final Predicate[] preds;

public And(Predicate... predicates) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the java doc of the constructor which style follows the OR, NOT etc:

/**
   * Creates an AND predicate.
   *
   * @param predicates The disjunctive predicates.
   */

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SteNicholas Done

Copy link
Copy Markdown
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @JingsongLi

@FangYongs
Copy link
Copy Markdown
Contributor Author

The test fails due to a known issue https://issues.apache.org/jira/browse/FLINK-31039

@FangYongs FangYongs force-pushed the FLINK-31032_and_predicate_for_orc branch from db2cdd8 to 16e6077 Compare February 14, 2023 01:40
@SteNicholas
Copy link
Copy Markdown
Member

@FangYongs, please reopen the pull request and rerun CI automatically.

@FangYongs FangYongs closed this Feb 14, 2023
@FangYongs FangYongs reopened this Feb 14, 2023
Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 39e8b77 into apache:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants