[FLINK-31309] Delete DFS schema when create table failed in HiveCatalog#575
Merged
JingsongLi merged 2 commits intoMar 6, 2023
Merged
Conversation
JingsongLi
reviewed
Mar 3, 2023
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @FangYongs , left two comments.
| " 'uri' = '',", | ||
| " 'warehouse' = '" + path + "',", | ||
| " 'metastore.client.class' = '" | ||
| + TestHiveMetaStoreClient.class.getName() |
Contributor
There was a problem hiding this comment.
Can you create a new class FailMetaStoreClient?
| } catch (TException e) { | ||
| Path path = getDataTableLocation(identifier); | ||
| try { | ||
| fileIO.delete(path, true); |
Contributor
There was a problem hiding this comment.
Maybe introduce a method in FileIO, deleteDirectoryQuietly?
Contributor
Author
|
Thanks @JingsongLi Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete DFS schema when create table failed in HiveCatalog