[FLINK-32410] Allocate hash-based collections with sufficient capacity for expected size#22841
Merged
StefanRRichter merged 4 commits intoapache:masterfrom Jun 30, 2023
Conversation
Collaborator
d8f3e1e to
8cf0f15
Compare
pnowojski
approved these changes
Jun 27, 2023
Contributor
pnowojski
left a comment
There was a problem hiding this comment.
LGTM assuming green build/no conflicts
9535590 to
8211eb8
Compare
…MapWithExpectedSize(size)
…SetWithExpectedSize(size)
…ewLinkedHashSetWithExpectedSize(size)
…ewLinkedHashMapWithExpectedSize(size)
8211eb8 to
5bc1273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The JDK API to create hash-based collections for a certain capacity is arguably misleading because it doesn't size the collections to "hold a specific number of items" like you'd expect it would. Instead it sizes it to hold "load-factor%" of the specified number.
For the common pattern to allocate a hash-based collection with the size of expected elements to avoid rehashes, this means that a rehash is essentially guaranteed.
This PR replaces constructor calls for allocations for expected size with helper methods (similar to Guava's
Maps.newHashMapWithExpectedSize(int)) .Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation