-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-17946][python] fix the bug that the config option 'pipeline.jars' doesn't work. #12372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c6d68db (Thu May 28 06:22:27 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
dianfu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WeiZhong94 Thanks for the fix, just two minor comments:
- Should we also execute
_before_execute()insql_update? - Could we also update the doc about
pipeline.jarsas it seems not correct?
|
@dianfu Thanks for your review! I have addressed your comments. It is unnecessary to execute |
|
@WeiZhong94 Thanks for the update. LGTM. |
dianfu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failure is a known issue which is tracked in FLINK-17260. Merging...
…rs' doesn't work. This closes apache#12372.
…rs' doesn't work. This closes #12372.
…rs' doesn't work. This closes apache#12372.
What is the purpose of the change
This pull request fixes the bug that the config option 'pipeline.jars' doesn't work.
Brief change log
Verifying this change
This change is already covered by existing tests, such as test_table_environment_api.py.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation