Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Jun 3, 2020

Bumps flink-shaded to 11.0 with an implicit zookeeper bump to 3.4.14 .

Required a small change in the SecureTestEnvironment for the Kafka010SecuredRunITCase to pass; it appears that zookeeper in 3.4.13+ behaves slightly differently in regards to 127.0.0.1/localhost; possibly related to ZOOKEEPER-2184.
It may be a good idea to verify this on MacOS, because on Windows this test still fails (due to Kafka siwtching between both hosts).
I do not know whether this has any relevance for production, but I assume no due to a lack of JIRA's on the matter.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4802492 (Wed Jun 03 13:43:52 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating Flink's flink-shaded version @zentol. I ran Kafka010SecuredRunITCase and YARNSessionFIFOSecuredITCase on MacOS and they passed. +1 for merging this PR.

@zentol zentol merged commit 826a075 into apache:master Jun 5, 2020
@zentol zentol deleted the 18042 branch June 18, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants