Skip to content

Conversation

@dawidwys
Copy link
Contributor

What is the purpose of the change

Fix links in documentation across languages

Verifying this change

Build the documentation.

IMPORTANT Do not use the -p or -i flags which serve the page. The build process is configured differently when only building vs when serving.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 16b22c5 (Tue Dec 15 08:51:56 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 15, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix.

The docs are building locally for me (without any -p / -i flags), build time is not worsening ;)

+1 to merge

@zentol
Copy link
Contributor

zentol commented Dec 15, 2020

FYI, this still fails locally for me if I'm not using the -p flags. With the -p flag it succeeds.

@zentol
Copy link
Contributor

zentol commented Dec 15, 2020

There may be similar problems in the sidenav.html; it appears to always refer to search-results.md.

@dawidwys
Copy link
Contributor Author

dawidwys commented Dec 15, 2020

Weren't the changes in sidenav.html reverted in:

@zentol
Copy link
Contributor

zentol commented Dec 15, 2020

With 06c8164 things are working.

@dawidwys
Copy link
Contributor Author

Thx for checking it! Merging.

@dawidwys dawidwys merged commit acd9aed into apache:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants