-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[FLINK-20422] Fix invalid links across languages #14385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 16b22c5 (Tue Dec 15 08:51:56 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fix.
The docs are building locally for me (without any -p / -i flags), build time is not worsening ;)
+1 to merge
|
FYI, this still fails locally for me if I'm not using the -p flags. With the -p flag it succeeds. |
|
There may be similar problems in the sidenav.html; it appears to always refer to search-results.md. |
|
With 06c8164 things are working. |
|
Thx for checking it! Merging. |
What is the purpose of the change
Fix links in documentation across languages
Verifying this change
Build the documentation.
IMPORTANT Do not use the
-por-iflags which serve the page. The build process is configured differently when only building vs when serving.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation