-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[FLINK-21938][docs] Add how to unit test python udfs #15360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a5bdc0a (Thu Sep 23 17:26:51 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@rmetzger Hi Robert, is there anything I need to do here? |
No, we have to wait for a reviewer to show up. @HuangXingBo could you take a look? |
@dianfu Hi Dian, can you please take a look? Thanks |
Sure. Very sorry for late response. |
@dianfu Feel free to let me know if you have any comments |
@YikSanChan I'm considering adding another page to hold this information instead of putting it inside ScalarFunction as it applies also to other kinds of user-defined functions. Besides the unit test, the page could also contain the other informations about user-defined function, e.g. logging, how to load a large data set, etc. |
@dianfu I agree with the proposal, though I don't have much experience on other udfs as well as logging/loading large dataset etc, therefore no sure what to add, correctly. Given this, do you like me to add something, or maybe we can move forward with this one (since the little-doc is better than no-doc)? |
@YikSanChan What about rebase this PR after that page is added. I can add that page. Will let you know when it is ready. Thank you a lot~ |
@dianfu Sure, that sounds good! Let me know when you add the page. 👍 |
What is the purpose of the change
Let users know how to unit test their Python scalar UDF.
Brief change log
Document how to unit test Python scalar UDF.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)No.
Documentation