Skip to content

Conversation

t0t07
Copy link
Contributor

@t0t07 t0t07 commented Mar 24, 2021

What is the purpose of the change

Let users know how to unit test their Python scalar UDF.

Brief change log

Document how to unit test Python scalar UDF.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

No.

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 24, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a5bdc0a (Thu Sep 23 17:26:51 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 24, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@t0t07
Copy link
Contributor Author

t0t07 commented Mar 29, 2021

@rmetzger Hi Robert, is there anything I need to do here?

@rmetzger
Copy link
Contributor

rmetzger commented Apr 4, 2021

No, we have to wait for a reviewer to show up. @HuangXingBo could you take a look?

@t0t07
Copy link
Contributor Author

t0t07 commented Apr 6, 2021

@dianfu Hi Dian, can you please take a look? Thanks

@dianfu
Copy link
Contributor

dianfu commented Apr 6, 2021

Sure. Very sorry for late response.

@t0t07
Copy link
Contributor Author

t0t07 commented Apr 7, 2021

@dianfu Feel free to let me know if you have any comments

@dianfu
Copy link
Contributor

dianfu commented Apr 7, 2021

@YikSanChan I'm considering adding another page to hold this information instead of putting it inside ScalarFunction as it applies also to other kinds of user-defined functions. Besides the unit test, the page could also contain the other informations about user-defined function, e.g. logging, how to load a large data set, etc.

@t0t07
Copy link
Contributor Author

t0t07 commented Apr 7, 2021

@dianfu I agree with the proposal, though I don't have much experience on other udfs as well as logging/loading large dataset etc, therefore no sure what to add, correctly. Given this, do you like me to add something, or maybe we can move forward with this one (since the little-doc is better than no-doc)?

@dianfu
Copy link
Contributor

dianfu commented Apr 7, 2021

@YikSanChan What about rebase this PR after that page is added. I can add that page. Will let you know when it is ready. Thank you a lot~

@t0t07
Copy link
Contributor Author

t0t07 commented Apr 7, 2021

@dianfu Sure, that sounds good! Let me know when you add the page. 👍

@dianfu dianfu closed this in 7063bf7 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants