Skip to content

Conversation

chaozwn
Copy link
Contributor

@chaozwn chaozwn commented Mar 29, 2021

…Calcite Parser

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 29, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b7efaba (Sat Aug 28 11:10:41 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 29, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your conribution. I left some comments.

stmt = SqlQueryOrDml() {
return new SqlRichExplain(getPos(),stmt);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line

Comment on lines 519 to 521
public void testExplainAsJson() {
// unsupport testExplainWithType now
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment:
// TODO: FLINK-20562

if (i == 0) {
statement = operand;
} else {
throw new AssertionError(i);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use meaningful exception message.

Comment on lines 149 to 148
case richExplain: SqlRichExplain =>
val validated = validator.validate(richExplain.getStatement)
richExplain.setOperand(0,validated)
richExplain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move forward before SqlExplain? Do we really need SqlExplain?

Comment on lines 514 to 516
public void testExplainAsXml() {
// unsupport testExplainWithType now
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment:
Don't supported feature. Escape the test.

Comment on lines 1225 to 1251
public void testExplainJsonFormat() {
// unsupport testExplainJsonFormat now
}

@Test
public void testExplainWithImpl() {
// unsupport testExplainWithImpl now
}

@Test
public void testExplainWithoutImpl() {
// unsupport testExplainWithoutImpl now
}

@Test
public void testExplainWithType() {
// unsupport testExplainWithType now
}

@Test
public void testExplainAsXml() {
// unsupport testExplainWithType now
}

@Test
public void testExplainAsJson() {
// unsupport testExplainWithType now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines 24 to 25
* Operation to describe an EXPLAIN statement. NOTES: currently, only default behavior(EXPLAIN xx)
* is supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain plan for is also supported.

Comment on lines 35 to 39
import org.apache.flink.sql.parser.ExtendedSqlNode
import org.apache.flink.sql.parser.dql._
import org.apache.flink.table.api.{TableException, ValidationException}
import org.apache.flink.table.catalog.CatalogReader
import org.apache.flink.table.parse.CalciteParser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollback

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me in general.

Comment on lines 99 to 101
.withIdentifierExpansion(true)
// Disable implicit type coercion for now.
.withTypeCoercionEnabled(false))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 2 space in scala file.

schemaPath: util.List[String],
viewPath: util.List[String])
: RelRoot = {
: RelRoot = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roll back


@Test
public void testExplainJsonFormat() {
// Don't supported feature. Escape the test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsupported feature.

Comment on lines +212 to +219
CREATE TABLE IF NOT EXISTS orders (
`user` BIGINT NOT NULl,
product VARCHAR(32),
amount INT,
ts TIMESTAMP(3),
ptime AS PROCTIME(),
PRIMARY KEY(`user`) NOT ENFORCED,
WATERMARK FOR ts AS ts - INTERVAL '1' SECONDS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please style the DDL as above. Add " " before fields

Comment on lines 24 to 25
* Operation to describe an EXPLAIN statement. NOTES: currently, only default behavior(EXPLAIN [plan
* for]* xx) is supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use UPPSER CASE "PLAN FOR"

Comment on lines 323 to 324
case e: TableException =>
assertTrue(e.getMessage.contains("Only default behavior is supported now"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this. It seems no one will getinto this branch? In my local environment, the test passes.

Comment on lines 543 to 544
case e: TableException =>
assertTrue(e.getMessage.contains("Only default behavior is supported now"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this. It seems no one will getinto this branch? In my local environment, the test passes.

import java.util.Collections;
import java.util.List;

/** EXPLAIN (plan for)* STATEMENT sql call. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use upper case.

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CC @wuchong

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong closed this in d84c216 Mar 30, 2021
fsk119 pushed a commit to fsk119/flink that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants