Skip to content

Conversation

lirui-apache
Copy link
Contributor

What is the purpose of the change

Copy more code from hive and move them to a dedicated package

Brief change log

  • Move the copied hive classes to package org.apache.flink.table.planner.delegation.hive.copy
  • Copy more hive code

Verifying this change

Existing tests

Does this pull request potentially affect one of the following parts:

NA

Documentation

NA

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 29, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8f3bef8 (Sat Aug 28 11:08:38 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 29, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@twalthr
Copy link
Contributor

twalthr commented Mar 29, 2021

@lirui-apache could you give the community more context about this change in the JIRA issue? I think most people in the Flink community would immediately reject copying more code from Hive to Flink unless there is a good reason for it.

@lirui-apache
Copy link
Contributor Author

Hi @twalthr The copied code is used to support hive dialect for different hive versions. And also allows us to extend hive syntax to support more features in the future. It was discussed in the Support Multiple Hive Versions section of FLIP-152.

@twalthr
Copy link
Contributor

twalthr commented Mar 29, 2021

@lirui-apache please always fill out the JIRA description. Even if it means copying the explanation from the FLIP. I got pinged to check this PR because it looks suspicious for people that are not familar with the topic.

@lirui-apache
Copy link
Contributor Author

@twalthr Sure, will do.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 5045ac1 into apache:master Mar 30, 2021
@lirui-apache lirui-apache deleted the FLINK-21998 branch March 30, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants