-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[FLINK-21998][hive] Copy more code from hive and move them to a dedicated package #15406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8f3bef8 (Sat Aug 28 11:08:38 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@lirui-apache could you give the community more context about this change in the JIRA issue? I think most people in the Flink community would immediately reject copying more code from Hive to Flink unless there is a good reason for it. |
@lirui-apache please always fill out the JIRA description. Even if it means copying the explanation from the FLIP. I got pinged to check this PR because it looks suspicious for people that are not familar with the topic. |
@twalthr Sure, will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Copy more code from hive and move them to a dedicated package
Brief change log
org.apache.flink.table.planner.delegation.hive.copy
Verifying this change
Existing tests
Does this pull request potentially affect one of the following parts:
NA
Documentation
NA