Skip to content

Conversation

@xintongsong
Copy link
Contributor

This is a copy of #15936, opened against the 1.12 branch, for CI verification.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2954bb2 (Thu Sep 23 17:21:49 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

KarmaGYZ added 2 commits June 3, 2021 17:27
…ge value for local execution

This fix is to avoid arithmetic overflow in calculating the resource overview of the minicluster.
…/process memory in creating TaskExecutorMemoryConfiguration

This closes apache#15936
@xintongsong xintongsong force-pushed the PR-15936-FLINK-22683-null-total-1.12 branch from 02105e5 to 2954bb2 Compare June 3, 2021 09:27
@xintongsong xintongsong changed the title FLINK-22683-release-1.12 [FLINK-22683][runtime] Fix the null or incorrect value of total flink/process memory in creating TaskExecutorMemoryConfiguration Jun 3, 2021
@xintongsong
Copy link
Contributor Author

@flinkbot run azure

xintongsong pushed a commit that referenced this pull request Jun 4, 2021
…/process memory in creating TaskExecutorMemoryConfiguration

This closes #16067
@xintongsong
Copy link
Contributor Author

68f1812

@xintongsong xintongsong closed this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants