Skip to content

[FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow #16205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow #16205

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63966a3
bugfix: if namespace not match namespaceSerializer
Jun 18, 2021
0e07e3b
bugfix: if namespace not match namespaceSerializer
Jun 18, 2021
6085b34
bugfix: Remove empty lines
Jun 18, 2021
984d966
Merge branch 'apache:master' into master
GuXiangFly Jun 23, 2021
c25b08e
Merge pull request #1 from apache/master
GuXiangFly Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...-runtime/src/main/java/org/apache/flink/runtime/state/CompositeKeySerializationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,13 @@ public static <N> void writeNameSpace(
throws IOException {

int beforeWrite = keySerializationDataOutputView.length();
namespaceSerializer.serialize(namespace, keySerializationDataOutputView);

// If the passed namespaceSerializer does not match the namespace, it should not serialize and should not write backendState
// Sharing state between trigger and TimeWindow causes inconsistencies in the namespace and NamespaceSerializer
if ((namespaceSerializer instanceof VoidNamespaceSerializer) && !(namespace instanceof VoidNamespace)){
return;
}
namespaceSerializer.serialize(namespace, keySerializationDataOutputView);
if (ambiguousKeyPossible) {
// write length of namespace
writeLengthFrom(beforeWrite, keySerializationDataOutputView);
Expand Down