[FLINK-4172] [gelly] Don't proxy a ProxiedObject #2213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vasia or @StephanEwen would you have a minute to look this over? I'll look to merge this for RC1. |
|
I am not an expert in the proxy magic of Gelly, but it looks fine to me. From my side, feel free to merge at your discretion... |
|
+1 to merge. The previously not working |
greghogan
force-pushed
the
4172_dont_proxy_a_proxiedobject
branch
from
91526d6 to
72bc8a2
Compare
greghogan
added a commit
to greghogan/flink
that referenced
this pull request
Jul 8, 2016
Retrieve the proxied object and wrap in a new proxy. This closes apache#2213
Retrieve the proxied object and wrap in a new proxy. This closes apache#2213
greghogan
force-pushed
the
4172_dont_proxy_a_proxiedobject
branch
from
72bc8a2 to
d1aee90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the proxied object and wrap in a new proxy.