-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[FLINK-35348][table] Introduce refresh materialized table rest api #24844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hackergin Thanks for contribution, I left some comments
...st-utils/src/main/java/org/apache/flink/table/file/testutils/TestFileSystemTableFactory.java
Outdated
Show resolved
Hide resolved
...st-utils/src/main/java/org/apache/flink/table/file/testutils/TestFileSystemTableFactory.java
Outdated
Show resolved
Hide resolved
...st-utils/src/main/java/org/apache/flink/table/file/testutils/TestFileSystemTableFactory.java
Outdated
Show resolved
Hide resolved
...flink/table/gateway/rest/message/materializedtable/MaterializedTableIdentifierParameter.java
Outdated
Show resolved
Hide resolved
...flink/table/gateway/rest/message/materializedtable/MaterializedTableIdentifierParameter.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointMaterializedTableITCase.java
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
sessionHandle, | ||
"SELECT * FROM my_materialized_table where ds = '2024-01-02'") | ||
.size()) | ||
.isEqualTo(getPartitionSize(data, "2024-01-02")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question: do we can check the result row content, not just only the partition result size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current materialized table is the result of aggregating the original table, so here only the size of result is compared.
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointMaterializedTableITCase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Introduce refresh materialized table rest api
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation