Skip to content

Conversation

hackergin
Copy link
Contributor

What is the purpose of the change

Introduce refresh materialized table rest api

Brief change log

  • test-filesystem support partition.fields option
  • Introduce refresh materialized table rest api

Verifying this change

  • Add test case in MaterializedTableITCase to verify refresh materialzied table.
  • Add test class SqlGatewayRestEndpointMaterializedTableITCase to verify refresh materialized table rest api.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (Will be added in a separated pr.)

@flinkbot
Copy link
Collaborator

flinkbot commented May 26, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@hackergin
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackergin Thanks for contribution, I left some comments

sessionHandle,
"SELECT * FROM my_materialized_table where ds = '2024-01-02'")
.size())
.isEqualTo(getPartitionSize(data, "2024-01-02"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question: do we can check the result row content, not just only the partition result size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current materialized table is the result of aggregating the original table, so here only the size of result is compared.

Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsyldliu lsyldliu merged commit 2c35e48 into apache:master May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants