-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38557][FileSystems] Bumped presto version from 0.272 to 0.295 #27209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
aa584a0 to
60f8555
Compare
- updated dependency version in NOTICE file as mentioned in https://cwiki.apache.org/confluence/display/FLINK/Licensing - excluded LICENSE files present in root directory causing CI failures - filtered the license files containing forbidden patterns causing CI failures
update the comments
|
@zentol , @tisonkun, @MartijnVisser can you please take a look on this PR. |
avi-sanwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like others to comment if the LGPL2.1 check exclusion is fine. But otherwise changes look good to me.
| // contained in flink-s3-fs-presto | ||
| .filter(path -> !pathStartsWith(path, "/com/sun/el")) | ||
| // contained in flink-s3-fs-presto | ||
| .filter(path -> !pathStartsWith(path, "/META-INF/LGPL2.1")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure LGPL2.1 can be excluded from checks: https://www.apache.org/legal/resolved.html#category-x
What is the purpose of the change
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation