Skip to content

Conversation

@mateczagany
Copy link
Contributor

@mateczagany mateczagany commented Nov 25, 2025

What is the purpose of the change

In a previous PR of mine (#27261), I mistakenly added jtokkit to the NOTICE file as a dependency with Apache 2.0 License, but it's actually under MIT license: https://github.com/knuddelsgmbh/jtokkit/blob/1.1.0/LICENSE

Please let me know if you think I should also open a Jira ticket for this instead of a hotfix.

Brief change log

  • Update jtokkit license to MIT in flink-model-openai NOTICE file

Verifying this change

  • Currently the only way to verify it is to manually check the license file and the project's license or the DEPENDENCIES file

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 25, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin snuyanzin merged commit 1e0045a into apache:master Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants