[FLINK-5615][query] execute the QueryableStateITCase for all three state back-ends #3194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 23, 2017 16:12
… state backends Querying for a non-existing key for a state that has a default value set currently results in an UnknownKeyOrNamespace exception when the MemoryStateBackend or FsStateBackend is used but results in the default value if RocksDBStateBackend is set. This removes the special handling from the RocksDBStateBackend and makes it consistent with the other two back-ends, i.e. returning null which results in the mentioned UnknownKeyOrNamespace exception.
…test duration This is based on the following points: * slow down QueryableStateITCase#TestKeyRangeSource for the rest of the program to make more progress (we do not need a full-speed source here!) * reduce the checkpointing interval * reduce the amount of progress before starting our own evaluation * reduce the number of checkpoints to wait for before killing a TM * reduce the thread waiting time when asking how many checkpoints exist Note that by slowing down QueryableStateITCase#TestKeyRangeSource, the other tests should only be affected positively, too, since they also did not really need a full-speed source and thus have more CPU cycles for their own tasks. This, among with
This is based on reducing the number of keys the source generates. We do not really need 1024 different keys for the tests - go with 256 now.
uce
requested changes
Jan 24, 2017
| * Several integration tests for queryable state using the {@link RocksDBStateBackend}. | ||
| */ | ||
| public class QueryableStateITCaseRocksDBBackend extends AbstractQueryableStateITCase { | ||
|
|
| * Several integration tests for queryable state using the {@link FsStateBackend}. | ||
| */ | ||
| public class QueryableStateITCaseFsBackend extends AbstractQueryableStateITCase { | ||
|
|
Thanks to @uce for proposing this.
|
Thanks for addressing the comments, merging. |
asfgit
pushed a commit
that referenced
this pull request
Jan 24, 2017
…ackends [FLINK-5615][query] improve testQueryableStateWithTaskManagerFailure test duration This is based on the following points: * slow down QueryableStateITCase#TestKeyRangeSource for the rest of the program to make more progress (we do not need a full-speed source here!) * reduce the checkpointing interval * reduce the amount of progress before starting our own evaluation * reduce the number of checkpoints to wait for before killing a TM * reduce the thread waiting time when asking how many checkpoints exist Note that by slowing down QueryableStateITCase#TestKeyRangeSource, the other tests should only be affected positively, too, since they also did not really need a full-speed source and thus have more CPU cycles for their own tasks. [FLINK-5615][query] speed up some more tests in QueryableStateITCase This is based on reducing the number of keys the source generates. We do not really need 1024 different keys for the tests - go with 256 now. [FLINK-5615][query] execute the QueryableStateITCase for all state back-ends [FLINK-5615][query] nicer test case abstraction This closes #3194.
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
…ackends [FLINK-5615][query] improve testQueryableStateWithTaskManagerFailure test duration This is based on the following points: * slow down QueryableStateITCase#TestKeyRangeSource for the rest of the program to make more progress (we do not need a full-speed source here!) * reduce the checkpointing interval * reduce the amount of progress before starting our own evaluation * reduce the number of checkpoints to wait for before killing a TM * reduce the thread waiting time when asking how many checkpoints exist Note that by slowing down QueryableStateITCase#TestKeyRangeSource, the other tests should only be affected positively, too, since they also did not really need a full-speed source and thus have more CPU cycles for their own tasks. [FLINK-5615][query] speed up some more tests in QueryableStateITCase This is based on reducing the number of keys the source generates. We do not really need 1024 different keys for the tests - go with 256 now. [FLINK-5615][query] execute the QueryableStateITCase for all state back-ends [FLINK-5615][query] nicer test case abstraction This closes apache#3194.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
QueryableStateITCaseso that it is able to run with any selected state backend. Some optimisations reduce the total runtime of the test cases so that we are able to run the tests with all three currently available backends, i.e.MemoryStateBackend,FsStateBackend, andRocksDBStateBackend, with little extra costs.This is based upon #3193.