[FLINK-5772] [elasticsearch] Allow Elasticsearch 1.x tests to rerun on failure #3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n failure This is allowed because Elasticsearch 1.x has a potential deadlock when creating indices. Since this flakiness rarely happens, this commit allows rerunning the Elasticsearch 1.x tests to try to mitigate this problem instead of just failing them.
|
+1 to merge |
|
Merging to |
p16i
pushed a commit
to p16i/flink
that referenced
this pull request
Apr 16, 2017
…n failure This is allowed because Elasticsearch 1.x has a potential deadlock when creating indices. Since this flakiness rarely happens, this commit allows rerunning the Elasticsearch 1.x tests to try to mitigate this problem instead of just failing them. This closes apache#3410.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that Elasticsearch 1.x tests can fail with this exception thrown from the embedded ES node used in IT tests:
ProcessClusterEventTimeoutException[failed to process cluster event (acquire index lock) within 1m].After some googling on this, it seems like this is a potential deadlock with Elasticsearch 1.x when creating indices.
From the looks of recent Travis tests, it seems that this flakiness rarely happens, so I think retrying the tests if they fail only for Elasticsearch 1.x and not newer versions would be a simple solution.
If it happens to pop out for 2.x and 5.x also, we might need to find another solution.