Skip to content

[FLINK-6210] close RocksDB in ListViaMergeSpeedMiniBenchmark && ListV… #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fanyon wants to merge 2 commits into from
Closed

[FLINK-6210] close RocksDB in ListViaMergeSpeedMiniBenchmark && ListV… #3652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0044c6
[FLINK-6210] close RocksDB in ListViaMergeSpeedMiniBenchmark && ListV…
Mar 30, 2017
caef37d
1. close options and write_options
Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 40 additions & 33 deletions ...va/org/apache/flink/contrib/streaming/state/benchmark/ListViaMergeSpeedMiniBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,52 +53,59 @@ public static void main(String[] args) throws Exception {
final String key = "key";
final String value = "abcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ7890654321";

final byte[] keyBytes = key.getBytes(StandardCharsets.UTF_8);
final byte[] valueBytes = value.getBytes(StandardCharsets.UTF_8);
try {
final byte[] keyBytes = key.getBytes(StandardCharsets.UTF_8);
final byte[] valueBytes = value.getBytes(StandardCharsets.UTF_8);

final int num = 50000;
final int num = 50000;

// ----- insert -----
System.out.println("begin insert");
// ----- insert -----
System.out.println("begin insert");

final long beginInsert = System.nanoTime();
for (int i = 0; i < num; i++) {
rocksDB.merge(write_options, keyBytes, valueBytes);
}
final long endInsert = System.nanoTime();
System.out.println("end insert - duration: " + ((endInsert - beginInsert) / 1_000_000) + " ms");
final long beginInsert = System.nanoTime();
for (int i = 0; i < num; i++) {
rocksDB.merge(write_options, keyBytes, valueBytes);
}
final long endInsert = System.nanoTime();
System.out.println("end insert - duration: " + ((endInsert - beginInsert) / 1_000_000) + " ms");

// ----- read (attempt 1) -----
// ----- read (attempt 1) -----

final byte[] resultHolder = new byte[num * (valueBytes.length + 2)];
final long beginGet1 = System.nanoTime();
rocksDB.get(keyBytes, resultHolder);
final long endGet1 = System.nanoTime();
final byte[] resultHolder = new byte[num * (valueBytes.length + 2)];
final long beginGet1 = System.nanoTime();
rocksDB.get(keyBytes, resultHolder);
final long endGet1 = System.nanoTime();

System.out.println("end get - duration: " + ((endGet1 - beginGet1) / 1_000_000) + " ms");
System.out.println("end get - duration: " + ((endGet1 - beginGet1) / 1_000_000) + " ms");

// ----- read (attempt 2) -----
// ----- read (attempt 2) -----

final long beginGet2 = System.nanoTime();
rocksDB.get(keyBytes, resultHolder);
final long endGet2 = System.nanoTime();
final long beginGet2 = System.nanoTime();
rocksDB.get(keyBytes, resultHolder);
final long endGet2 = System.nanoTime();

System.out.println("end get - duration: " + ((endGet2 - beginGet2) / 1_000_000) + " ms");
System.out.println("end get - duration: " + ((endGet2 - beginGet2) / 1_000_000) + " ms");

// ----- compact -----
System.out.println("compacting...");
final long beginCompact = System.nanoTime();
rocksDB.compactRange();
final long endCompact = System.nanoTime();
// ----- compact -----
System.out.println("compacting...");
final long beginCompact = System.nanoTime();
rocksDB.compactRange();
final long endCompact = System.nanoTime();

System.out.println("end compaction - duration: " + ((endCompact - beginCompact) / 1_000_000) + " ms");
System.out.println("end compaction - duration: " + ((endCompact - beginCompact) / 1_000_000) + " ms");

// ----- read (attempt 3) -----
// ----- read (attempt 3) -----

final long beginGet3 = System.nanoTime();
rocksDB.get(keyBytes, resultHolder);
final long endGet3 = System.nanoTime();
final long beginGet3 = System.nanoTime();
rocksDB.get(keyBytes, resultHolder);
final long endGet3 = System.nanoTime();

System.out.println("end get - duration: " + ((endGet3 - beginGet3) / 1_000_000) + " ms");
System.out.println("end get - duration: " + ((endGet3 - beginGet3) / 1_000_000) + " ms");
} finally {
rocksDB.close();
Copy link

@shixiaogang shixiaogang Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides RocksDB, Options andWriteOptions should also be closed here.

Copy link

@shixiaogang shixiaogang Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to delete the RocksDB's directory here.

options.close();
write_options.close();
FileUtils.deleteDirectory(rocksDir);
}
}
}
95 changes: 53 additions & 42 deletions ...va/org/apache/flink/contrib/streaming/state/benchmark/ListViaRangeSpeedMiniBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,57 +56,68 @@ public static void main(String[] args) throws Exception {

final String key = "key";
final String value = "abcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ7890654321";

try {

final byte[] keyBytes = key.getBytes(StandardCharsets.UTF_8);
final byte[] valueBytes = value.getBytes(StandardCharsets.UTF_8);
final byte[] keyBytes = key.getBytes(StandardCharsets.UTF_8);
final byte[] valueBytes = value.getBytes(StandardCharsets.UTF_8);

final byte[] keyTemplate = Arrays.copyOf(keyBytes, keyBytes.length + 4);
final byte[] keyTemplate = Arrays.copyOf(keyBytes, keyBytes.length + 4);

final Unsafe unsafe = MemoryUtils.UNSAFE;
final long offset = unsafe.arrayBaseOffset(byte[].class) + keyTemplate.length - 4;
final Unsafe unsafe = MemoryUtils.UNSAFE;
final long offset = unsafe.arrayBaseOffset(byte[].class) + keyTemplate.length - 4;

final int num = 50000;
System.out.println("begin insert");
final int num = 50000;
System.out.println("begin insert");

final long beginInsert = System.nanoTime();
for (int i = 0; i < num; i++) {
unsafe.putInt(keyTemplate, offset, i);
rocksDB.put(write_options, keyTemplate, valueBytes);
}
final long endInsert = System.nanoTime();
System.out.println("end insert - duration: " + ((endInsert - beginInsert) / 1_000_000) + " ms");

final byte[] resultHolder = new byte[num * valueBytes.length];

final long beginGet = System.nanoTime();

final RocksIterator iterator = rocksDB.newIterator();
int pos = 0;

// seek to start
unsafe.putInt(keyTemplate, offset, 0);
iterator.seek(keyTemplate);

// mark end
unsafe.putInt(keyTemplate, offset, -1);

// iterate
while (iterator.isValid()) {
byte[] currKey = iterator.key();
if (samePrefix(keyBytes, currKey)) {
byte[] currValue = iterator.value();
System.arraycopy(currValue, 0, resultHolder, pos, currValue.length);
pos += currValue.length;
iterator.next();
final long beginInsert = System.nanoTime();
for (int i = 0; i < num; i++) {
unsafe.putInt(keyTemplate, offset, i);
rocksDB.put(write_options, keyTemplate, valueBytes);
}
else {
break;
final long endInsert = System.nanoTime();
System.out.println("end insert - duration: " + ((endInsert - beginInsert) / 1_000_000) + " ms");

final byte[] resultHolder = new byte[num * valueBytes.length];

final long beginGet = System.nanoTime();

final RocksIterator iterator = rocksDB.newIterator();
Copy link

@shixiaogang shixiaogang Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iterator should be closed once it's not used. So it's better to use try-with-resources here.

int pos = 0;

try {
// seek to start
unsafe.putInt(keyTemplate, offset, 0);
iterator.seek(keyTemplate);

// mark end
unsafe.putInt(keyTemplate, offset, -1);

// iterate
while (iterator.isValid()) {
byte[] currKey = iterator.key();
if (samePrefix(keyBytes, currKey)) {
byte[] currValue = iterator.value();
System.arraycopy(currValue, 0, resultHolder, pos, currValue.length);
pos += currValue.length;
iterator.next();
} else {
break;
}
}
}finally {
iterator.close();
}
}

final long endGet = System.nanoTime();
final long endGet = System.nanoTime();

System.out.println("end get - duration: " + ((endGet - beginGet) / 1_000_000) + " ms");
System.out.println("end get - duration: " + ((endGet - beginGet) / 1_000_000) + " ms");
} finally {
rocksDB.close();
Copy link

@shixiaogang shixiaogang Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the problem mentioned above, all RocksDB objects should be closed once they are not used.

options.close();
write_options.close();
FileUtils.deleteDirectory(rocksDir);
}
}

private static boolean samePrefix(byte[] prefix, byte[] key) {
Expand Down