Make Expression API available to Java, Rename it to Table API #503
Conversation
|
We had a discussion on the dev mailing list regarding the name of the API which was leaning a bit towards Table API / DataTable, but I don't think we had a consensus there, right? |
|
Correct, that's why I'm doing a Pull Request. People can chime in here if they want. Or should we continue the discussion on the mailing list? I though everyone would be more or less happy with Table. |
aljoscha
force-pushed
the
flinq-rework
branch
3 times, most recently
from
eef986d to
6608c6b
Compare
|
I think @fhueske just suggetsing it would be less work to have the new name settle before PR being submmitted. |
|
Exactly, thanks @hsaputra |
|
Gah, I just did that in the discuss thread =P |
|
Touché |
docs/linq.md
Outdated
|
The code looks good. Impressive test coverage, some documentation, amazing feature. Do you think it would be a good idea to add the grammar of the parser to the documentation? |
|
I fixed @rmetzger's remarks. Still waiting for a solution to the naming issue. |
Package name is now flink-table. ExpressionOperation is renamed to Table. This also adds more JavaDoc and ScalDoc.
* [FRT-317] Adds data plane auth support and config flag * Revert "[FLINK-34150][ci] Enables local file sink e2e tests in general CI setups" This reverts commit 6e96772. --------- Co-authored-by: Panagiotis Garefalakis <pgaref@apache.org>
5 participants
This also adds tests and more Javadoc documentation for the Table API.