[FLINK-10150][metrics] Fix OperatorMetricGroup creation for Batch #6599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes a severe issue in the metric system where chained batch operators would always operate on the same
OperatorMetricGroup
. As a result most Flink-provided metrics were not exposed for chained operators at all, while other metrics, like task-level IO metrics, were rendered incorrect.The problem is that we used the tasks
VertexID
to identify operators; which is obviously identical for all operators in a chain. We now use the vertexID and operator name to identify them.Brief change log
TaskMetricGroup
by using both the ID and operator nameMockEnvironment[Builder]
to allow theTaskMetricGroup
to be setVerifying this change
This change added tests: