add OMS monitoring support for azure installations #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds OMS agent to azure installations for monitoring VMs via Azure Monitor services, specifically log analytics. Also includes the following enhancements/fixes: - remove quotes from cidr in muchos.props.example - add extra-var coercion for boolean values to boolean types Implements: apache#282
ctubbsii
approved these changes
Sep 19, 2019
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Although I'm not familiar with Azure's OMS monitoring support, I see no obvious issues with this change that would prevent it from being merged.
Member
|
Thanks for the contribution @sputnik13 ! If you would like to be listed as contributor, please edit Fluo's people page. The Apache Fluo project tweets about first contributions. If you any of you would like a tweet to be made about this PR, just let me know what twitter handles to include in the tweet. In addition to being listed as contributor, if you are interested in continuing to contribute to Fluo, please consider subscribing to the developer mailing list and introducing yourself on that list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OMS agent to azure installations for monitoring VMs via Azure
Monitor services, specifically log analytics.
Also includes the following enhancements/fixes:
Implements: #282