Skip to content

Conversation

@arvindshmicrosoft
Copy link
Member

Fixes #291

@keith-turner keith-turner merged commit f763f62 into apache:master Oct 9, 2019
@ctubbsii
Copy link
Member

ctubbsii commented Oct 9, 2019

Thanks, @arvindshmicrosoft . A quick note:

I see that you created #291, and then exactly one minute later, submitted this PR #292 to fix it. Some projects might require a separate issue, but we don't require that. GitHub treats PRs as issues, so it's fine to just do the PR in situations like this.

Sometimes, it can be helpful to have a separate issue, as in:

  • reporting a bug immediately, and troubleshooting later,
  • discussion would be useful before beginning work,
  • reporting a bug for somebody else to work on,
  • creating a parent task for tracking multiple sub-tasks,
  • creating one issue, but different PRs for different branches,
  • etc.

But, it's not always helpful, so we don't require it. A PR is fine by itself. Use your discretion, of course. 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning starting YARN 2.x

3 participants