Apply #266 fix to Hadoop HA role #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-turner
approved these changes
Dec 16, 2019
Contributor
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
Along with this fix, I have also included the missing hadoop-metrics2.properties to hadoop-ha role. Let me know if this needs a separate PR?
This is fine.
arvindshmicrosoft
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #266 was already applied to
hadooprole. This PR extends the same fix tohadoop-harole, introduced in #284Along with this fix, I have also included the missing
hadoop-metrics2.propertiestohadoop-harole. Let me know if this needs a separate PR?Many thanks,