Skip to content

Fix wipe command for cluster_type 'existing' #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arvindshmicrosoft merged 1 commit into from
Apr 13, 2020
Merged

Fix wipe command for cluster_type 'existing' #339

arvindshmicrosoft merged 1 commit into from
Apr 13, 2020

Conversation

@arvindshmicrosoft
Copy link
Member

@arvindshmicrosoft arvindshmicrosoft commented Apr 10, 2020

  • Call wipe.yml for existing clusters as well
  • Minor refactor of associated wipe() methods

@arvindshmicrosoft
Fix wipe command for cluster_type 'existing'
89dd32d 
* Call wipe.yml for existing clusters as well
* Minor refactor of associated wipe() methods
@arvindshmicrosoft
Copy link
Member Author

arvindshmicrosoft commented Apr 12, 2020

For context, I believe the Python refactor PR done last year introduced this regression. The symptom is that attempting to wipe a cluster of type 'existing' returns the below error:

Killing all processes started by Muchos and wiping Muchos data from mycluster cluster
Traceback (most recent call last):
  File "/home/arviadmin/upstream_apache/fluo-muchos/lib/main.py", line 83, in <module>
    main()
  File "/home/arviadmin/upstream_apache/fluo-muchos/lib/main.py", line 67, in main
    cluster.perform(action)
  File "/home/arviadmin/upstream_apache/fluo-muchos/lib/muchos/existing.py", line 236, in perform
    self.wipe()
AttributeError: 'ExistingCluster' object has no attribute 'wipe'

keith-turner
keith-turner approved these changes Apr 13, 2020
View reviewed changes
lib/muchos/existing.py
tdir=target), shell=True)

def wipe(self):
if not isfile(self.config.hosts_path):
Copy link
Contributor

@keith-turner keith-turner Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement brining this in one place so all implementations benefit.

@arvindshmicrosoft arvindshmicrosoft merged commit 5360302 into apache:master Apr 13, 2020
Manno15 pushed a commit to Manno15/fluo-muchos that referenced this pull request Jul 29, 2020
@arvindshmicrosoft @Manno15
Fix wipe command for cluster_type 'existing' (apache#339)
45c9d4c 
* Call wipe.yml for existing clusters as well
* Minor refactor of associated wipe() methods
@arvindshmicrosoft arvindshmicrosoft deleted the wipe-existing branch September 29, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keith-turner keith-turner keith-turner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arvindshmicrosoft @keith-turner