Closed file system which is not eventually closed.#985
Closed
kamaci wants to merge 2 commits intoapache:masterfrom
kamaci:master
Closed
Closed file system which is not eventually closed.#985kamaci wants to merge 2 commits intoapache:masterfrom kamaci:master
kamaci wants to merge 2 commits intoapache:masterfrom
kamaci:master
Conversation
keith-turner
requested changes
Dec 22, 2017
Contributor
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
@kamaci welcome to the Apache Fluo community and thanks for the contribution. I tested this locally to ensure it did not negatively impact the Fluo worker process and the change worked great.
After the formatting issue is fixed I can merge this.
| if (downloadPathFile.exists()) { | ||
| FileUtils.deleteDirectory(downloadPathFile); | ||
| } | ||
| fs.copyToLocalFile(new Path(config.getObserverJarsUrl()), new Path(opts.getDownloadPath())); |
Contributor
There was a problem hiding this comment.
I built and tested this locally, I noticed this line was reformatted. Fluo uses Maven plugins to automatically format the code. If you run mvn compile locally you should see that this line is reformatted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed the filesystem.