[KV] Avoid TabletServer to discard already commited kv snapshot #1738
Conversation
fluss-server/src/main/java/org/apache/fluss/server/kv/snapshot/KvTabletSnapshotTarget.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/snapshot/KvTabletSnapshotTarget.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/snapshot/KvTabletSnapshotTarget.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/kv/snapshot/KvTabletSnapshotTarget.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/org/apache/fluss/server/kv/snapshot/KvTabletSnapshotTargetTest.java
Show resolved
Hide resolved
platinumhamburg
force-pushed
the
kv-commit
branch
from
4ee4e6e to
41b691f
Compare
|
@wuchong Thank you for your review. I have addressed all the comments above, except for the handling of undetermined snapshots, which I still treat as failures. I've explained the reasoning behind this decision above. Please review again when you have time. |
fluss-server/src/main/java/org/apache/fluss/server/kv/snapshot/KvTabletSnapshotTarget.java
Outdated
Show resolved
Hide resolved
|
Hi @platinumhamburg , I left a comment about the snapshot cleanup, and a minor comment in the review. Please let me know your thoughts. |
Hi @wuchong , I agree that your suggestion is a better approach to handle the ZooKeeper query exception. I've modified my implementation accordingly and fixed another minor issue. Thanks for reviewing this again. |
|
@platinumhamburg thanks for the updates. LGTM. |
2 participants
Purpose
Linked issue: close #1304
Brief change log
Tests
API and Format
Documentation