-
Notifications
You must be signed in to change notification settings - Fork 150
FOP-2847: Support palette-based transparency via tRNS chunk of PNG im… #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
7obywankenobi
wants to merge
7,990
commits into
apache:trunk
from
7obywankenobi:fop2847_support_palette_based_transparency_via_tRNS_chunk_of_PNG
Closed
FOP-2847: Support palette-based transparency via tRNS chunk of PNG im… #55
7obywankenobi
wants to merge
7,990
commits into
apache:trunk
from
7obywankenobi:fop2847_support_palette_based_transparency_via_tRNS_chunk_of_PNG
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1685770 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1686451 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1687457 13f79535-47bb-0310-9956-ffa450edef68
… Hussein Shafie. git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1687458 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1687510 13f79535-47bb-0310-9956-ffa450edef68
… purposes git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1690138 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1690396 13f79535-47bb-0310-9956-ffa450edef68
…ven/-odd git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1690781 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1693102 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1693610 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1693613 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1693719 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_PCLSoftFonts@1694075 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1694450 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1695041 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1695082 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1695225 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1695313 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1695517 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1695526 13f79535-47bb-0310-9956-ffa450edef68
…chreiber git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1703427 13f79535-47bb-0310-9956-ffa450edef68
…as suggested by dvineshkumar@gmail.com git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1705133 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1713620 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1713641 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1715212 13f79535-47bb-0310-9956-ffa450edef68
…gested by sdridi@iptech-group.com. git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1716732 13f79535-47bb-0310-9956-ffa450edef68
…e: r1716732) git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1716743 13f79535-47bb-0310-9956-ffa450edef68
…eException (i.e. reported as errors) and AssertionException (i.e. reported as failure) git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1716744 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1716758 13f79535-47bb-0310-9956-ffa450edef68
…ssignment + start of javadoc fixups git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1716765 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1835225 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1835524 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1835526 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1835810 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1836268 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1839651 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1839669 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1839970 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1841574 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1841594 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1842844 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1843302 13f79535-47bb-0310-9956-ffa450edef68
…and patterns git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1843494 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1843507 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1843560 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1843563 13f79535-47bb-0310-9956-ffa450edef68
…me location git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1844636 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1845493 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1845792 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1846994 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1849455 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1851362 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1851806 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1853576 13f79535-47bb-0310-9956-ffa450edef68
…ages in PDF export java.awt.image.BufferedImage.getAlphRaster() return null if an IndexColorModel is used. This resulted in those PNGs missing the SMask and had broken transparency effects. PNG images with indexed color palette featuring tRNS transparency encoding had potentially wrong PDF Mask. If image contained transparency but no fully transparent pixel, then the default implementation of PDFImageXObject still generates a Mask entry with three color components. PDF Specification expects the index when using a palette based color model. Thus Acrobat Reader does not process this image and shows an error message. In general ImageRenderedAdapter would overwrite this Mask, but since AbstractImageAdapter.getIndexOfFirstTransparentColorInPalette() does return null if image does not contain fully transparent pixels the more general implementation of PDFImageXObject leaks to the output. This has been fixed.
This was referenced Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ages in PDF export
java.awt.image.BufferedImage.getAlphRaster() return null if an
IndexColorModel is used. This resulted in those PNGs missing the
SMask and had broken transparency effects.
PNG images with indexed color palette featuring tRNS transparency
encoding had potentially wrong PDF Mask. If image contained transparency
but no fully transparent pixel, then the default implementation of
PDFImageXObject still generates a Mask entry with three color components.
PDF Specification expects the index when using a palette based color
model. Thus Acrobat Reader does not process this image and shows an
error message. In general ImageRenderedAdapter would overwrite this
Mask, but since
AbstractImageAdapter.getIndexOfFirstTransparentColorInPalette() does
return null if image does not contain fully transparent pixels the
more general implementation of PDFImageXObject leaks to the output.
This has been fixed.