Skip to content

fix zh-cn doc#159

Merged
chaokunyang merged 3 commits intoapache:mainfrom
chaokunyang:fix_zh_cn_doc
Aug 21, 2024
Merged

fix zh-cn doc#159
chaokunyang merged 3 commits intoapache:mainfrom
chaokunyang:fix_zh_cn_doc

Conversation

@chaokunyang
Copy link
Contributor

@chaokunyang chaokunyang commented Aug 21, 2024

Closes #157

@chaokunyang
Copy link
Contributor Author

chaokunyang commented Aug 21, 2024

image
@yuluo-yx do you know how to make markdown-link-check component print broken links?

@yuluo-yx
Copy link
Member

image

at the top @chaokunyang

locales: ['en-us', 'zh-CN'],
path: 'i18n',
localeConfigs: {
'en-us': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harmonize them to eu-US, what do you think? @chaokunyang

@chaokunyang
Copy link
Contributor Author

image

at the top @chaokunyang
That would be tricky, we have not deploy new pages, so the links will already be broken. I will disable this check temporarily and reable it later. In the long run, maybe we need to deploy a local version and replace all links for checks.

@chaokunyang chaokunyang merged commit 4ac5821 into apache:main Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Site]: All chinese pages return Not Found

2 participants