feat(java): add DescriptorBuilder for easy build and copying Descriptor#2229
Merged
chaokunyang merged 3 commits intoapache:mainfrom May 13, 2025
Merged
feat(java): add DescriptorBuilder for easy build and copying Descriptor#2229chaokunyang merged 3 commits intoapache:mainfrom
chaokunyang merged 3 commits intoapache:mainfrom
Conversation
Hen1ng
changed the title
chaokunyang
reviewed
May 13, 2025
| return this; | ||
| } | ||
|
|
||
| public DescriptorBuilder snakeCaseName(String snakeCaseName) { |
Collaborator
There was a problem hiding this comment.
This should be consistent with name, when building descriptor, we set snakeCaseName automatically in the constructor.
chaokunyang
reviewed
May 13, 2025
| this.furyField = builder.furyField; | ||
| } | ||
|
|
||
| public Descriptor copy(Method readMethod, Method writeMethod) { |
Collaborator
There was a problem hiding this comment.
Could we also add a copyBuilder() method in Descriptor to simplify the usage. And could we add a test?
chaokunyang
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related issues
#2222
Does this PR introduce any user-facing change?
Benchmark