fix(C++): Fix reversed parameters and incorrect calls in string_util benchmark#2246
Merged
pandalee99 merged 5 commits intoapache:mainfrom May 19, 2025
lzaeh:feat/improve-benchmark-uti
Merged
fix(C++): Fix reversed parameters and incorrect calls in string_util benchmark#2246pandalee99 merged 5 commits intoapache:mainfrom lzaeh:feat/improve-benchmark-uti
pandalee99 merged 5 commits intoapache:mainfrom
lzaeh:feat/improve-benchmark-uti
Conversation
… replace auto with explicit types; optimize implementation
pandalee99
reviewed
May 19, 2025
pandalee99
reviewed
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes several minor issues and improves the implementation of string utility benchmarks:
One part of the original code used default random generation methods, which could result in uneven value distributions and non-deterministic behavior across platforms. To improve randomness quality and thread-safety, I replaced it with a
thread_localencapsulatedstd::mt19937generator. This ensures better reproducibility and consistency during benchmarking.After these changes, the code compiles and runs correctly. Benchmark results are stable and as expected. (See image below.)
Related issues
Does this PR introduce any user-facing change?
Benchmark