Validation within unit test does not work in Grails 3.2 (3.2.1)

[saw303]

nullable: true does not work within unit tests. The following test describes the problem.

// when @TestFor is removed test fails
//@TestFor(IndividualPerson)
class IndividualPersonSpec extends HibernateSpec {

    @Override
    List<Class> getDomainClasses() {
        [Address, IndividualPerson, Season, User, InvoiceAddress]
    }

    void "Validation fails"() {
        given:
        def member = new IndividualPerson(firstname: 'helo', name: 'wangler', memberSince: '2014', active: Boolean.TRUE)

        when:
        def valid = member.validate()

        and:
        member.save()

        then: 'validation fails'
        valid

        and: 'and of course member is null'
        member.id
    }
}

Steps to Reproduce

1. Checkout Grails 3.2.1 app
2. Run test

Expected Behaviour

Validation should work as in production mode.

Actual Behaviour

Validation nullable: true is not respected

Environment Information

• Operating System: macOS Sierra
• Grails Version: 3.2.1
• JDK Version: 1.8

Example Application

• see above

[graemerocher]

Can probably be worked around with:

def setup() {
        def mappingContext = hibernateDatastore.mappingContext
        mappingContext.setValidatorRegistry(new DefaultValidatorRegistry(mappingContext, hibernateDatastore.connectionSources.baseConfiguration))
}

[saw303]

I modified the test as you suggested. It did not work the issue around.

class IndividualPersonSpec extends HibernateSpec {

    @Override
    List<Class> getDomainClasses() {
        [Address, IndividualPerson, Season, User, InvoiceAddress]
    }

    def setup() {
        MappingContext mappingContext = hibernateDatastore.mappingContext
        mappingContext.setValidatorRegistry(new DefaultValidatorRegistry(mappingContext, hibernateDatastore.connectionSources.baseConfiguration))
    }

    void "Validation fails"() {
        given:
        def member = new IndividualPerson(firstname: 'helo', name: 'wangler', memberSince: '2014', active: Boolean.TRUE)

        when:
        def valid = member.validate()

        and:
        member.save()

        then: 'validation fails'
        valid

        and: 'and of course member is null'
        member.id
    }
}

[jeffscottbrown]

I think this is likely an issue with the hibernate plugin in particular and probably should be filed at https://github.com/grails/gorm-hibernate5/issues.

I think both of the following will pass:

package grails.issues

import grails.test.mixin.Mock
import spock.lang.Specification

@Mock(IndividualPerson)
class IndividualPersonSpec extends Specification {

    void "test validation"() {
        given:
        def member = new IndividualPerson(firstname: 'helo', name: 'wangler', memberSince: '2014', active: Boolean.TRUE)

        when:
        def valid = member.validate()

        and:
        member.save()

        then:
        valid

        and:
        member.id
    }
}

package grails.issues

import grails.test.mixin.TestFor
import spock.lang.Specification

@TestFor(IndividualPerson)
class IndividualPersonSpec extends Specification {

    void "test validation"() {
        given:
        def member = new IndividualPerson(firstname: 'helo', name: 'wangler', memberSince: '2014', active: Boolean.TRUE)

        when:
        def valid = member.validate()

        and:
        member.save()

        then:
        valid

        and:
        member.id
    }
}

[saw303]

Using TestFor or Mock does the job as expected.

Currently I have a problem with a unit test (using the HibernateTestMixin) that acutally tests a Grails service class. Therefore the test declares @TestFor(MyServiceClass). Within this test class I call a service method that creates new domain object instances (this domain object contains field constraints nullable:true). In Grails 3.2 the save method fails since the constraint validation does not work properly for nullable constraints.

I haven't found a way to work this around yet.