-
-
Notifications
You must be signed in to change notification settings - Fork 967
Description
Task List
- Steps to reproduce provided
- Stacktrace (if present) provided
- Example that reproduces the problem uploaded to Github
- Full description of the issue provided (see below)
Actual Behaviour
Grails has it's own DomainValidator -> https://github.com/grails/grails-core/blob/master/grails-validation/src/main/groovy/org/grails/validation/routines/DomainValidator.java but EmailValidator was not ported/implemented.
Because of that, EmailConstraint uses EmailValidator from Apache commons-validator https://github.com/grails/grails-core/blob/master/grails-validation/src/main/groovy/org/grails/validation/EmailConstraint.java#L69 which relies on org.apache.commons.validator.routines.DomainValidator.
I already opened two prs
#10252 <- Updates Generic TLDs for org.grails.validation.routines.DomainValidator
#10253 <- Updates grails-validation/build.gradle to upgrade commons-validator to latest version 1.5.1 that way the EmailValidator will support the latest Generic TLDs.
Expected Behaviour
EmailConstraint should use a org.grails.validation.routines.EmailValidator that relies on org.grails.validation.routines.DomainValidator.
Environment Information
- Grails Version: 3.2.1