Skip to content

Conversation

@jameskleeh
Copy link
Contributor

Improving the link generator to use the namespace in the request uncovered 2 additional bugs.

  1. The url mappings for /$namespace/$controler... would never be found to generate correct URLS
  2. The link generator was previously passing pluginName to the namespace variable when creating URLs. That prevented a bug with the plugin name getting appended as URL parameter from showing. After passing all arguments to the createRelativeURL method, URLs like ?pluginName=foo were being created. I had to add usedParams.add("plugin"); to RegexUrlMappings.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants