Skip to content

Encode as html select option values #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Encode as html select option values #10257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion grails-plugin-gsp/src/main/groovy/org/grails/plugins/web/taglib/FormTagLib.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ class FormTagLib implements ApplicationContextAware, InitializingBean, TagLibrar
}
}
keyValue = processFormFieldValueIfNecessary(selectName, "${keyValue}","option")
writer << "value=\"${keyValue}\" "
writer << "value=\"${keyValue.toString().encodeAsHTML()}\" "
if (selected) {
writer << 'selected="selected" '
}
Expand Down
8 changes: 8 additions & 0 deletions grails-test-suite-web/src/test/groovy/org/grails/web/taglib/SelectTagTests.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ class SelectTagTests extends AbstractGrailsTagTests {
assertTrue "should have HTML escaped attributes", result.startsWith('<select id="bar&quot; /&gt;&lt;script&gt;alert(&quot;gotcha&quot;)&lt;/script&gt;.genre" name="bar&quot; /&gt;&lt;script&gt;alert(&quot;gotcha&quot;)&lt;/script&gt;.genre" >')
}

void testSelectTagEscapingValue() {
def template = '<g:select id="genre" name="genre" from="${values}" />'
def result = applyTemplate(template, [values: ["\"></option></select><script>alert('hi')</script>"]])

println result
assertTrue "should have HTML escaped values", result.contains('<option value="&quot;&gt;&lt;/option&gt;&lt;/select&gt;&lt;script&gt;alert(&#39;hi&#39;)&lt;/script&gt;" >&quot;&gt;&lt;/option&gt;&lt;/select&gt;&lt;script&gt;alert(&#39;hi&#39;)&lt;/script&gt;</option>')
}

void testSelectUsesExpressionForDisable() {
def template = '<g:set var="flag" value="${true}"/><g:select disabled="${flag}" name="foo" id="foo" from="[1,2,3]" />'
assertOutputContains('disabled="disabled"', template)
Expand Down