Fix for #10403 - 3.1.x version - Recognize properties with the second letter capitalized #10414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make ClassPropertyFetcher also recognize properties of the form "xAge" that have the second letter capitalized. Fixes apache#10403
Contributor
|
It doesn't compile currently |
GrailsClassUtils.getPropertyForGetter/Setter would previously return property names for some method names that were not valid getters or setters, although the documentation says they return null in those cases. This change improves the detection and makes sure only valid getters/setters result in a property name. This commit includes updates in the documentation of related methods to more clearly indicate what is accepted and what not, and what assumptions are made. This also includes a bunch of new test cases.
Re-use GrailsNameUtils.getPropertyForGetter from ClassPropertyFetcher instead of having separate (and wrong) logic. This commit has a small behavioral change in that the old code would register both "Property" and "property" for a static property with a getter "getProperty" in ClassPropertyFetcher. With improved property name derivation that should not be necessary anymore.
Contributor
Author
|
@graemerocher I noticed. It's fixed now, tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of PR #10404 but against
3.1.xinstead of againstmaster.Make GrailsNameUtils.getPropertyForGetter/Setter do the same checks as .isGetter to decide if a name is a valid getter, and return null otherwise
Make ClassPropertyFetcher also recognize properties of the form "xAge" that have the second letter capitalized, by using the functionality from GrailsNameUtils.getPropertyForGetter instead of using it's own copy of (almost) the same logic.
Fixes #10403