Gradle Plugin Fix - remove calls to setSystemProperty() and set on individual tasks instead #15221
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
changed the title
Contributor
Author
|
Fixes #15222 |
jamesfredley
approved these changes
Nov 10, 2025
codeconsole
approved these changes
Nov 10, 2025
matrei
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an extremely frustrating bug for multiproject builds. The gradle plugins were calling System.setProperty() as part of any grails gradle plugin setup - which means the set Property is for the life of that jvm instance. Since gradle is threaded, with multiproject builds, it resulted in a race condition / random setting of this field. This meant that the basedir was incorrectly set for bootRun, etc. It was even complicated more in that if it was set for that daemon process, it would remain set.
We already set other properties as part of task execution, so this PR takes the same approach. This does mean that the properties are no longer set for gradle code, but after testing, I think this is ok.