Add versions to banner

[matrei]

Will by default output versions below banner like:

    >                                                                            <
    >                            ____           _ _                              <
    >                           / ___|_ __ __ _(_) |___                          <
    >                          | |  _| '__/ _` | | / __|                         <
    >                          | |_| | | | (_| | | \__ \                         <
    >                           \____|_|  \__,_|_|_|___/                         <
    >                          https://grails.apache.org/                        <
    >                                                                            <
            grails-test-examples-async-events-pubsub-demo: 7.1.0-SNAPSHOT         
           JVM: BellSoft 17.0.17 | Grails: 7.1.0-SNAPSHOT | Groovy: 4.0.29        
                         Spring Boot: 3.5.7 | Spring: 6.2.12

See documentation changes in this PR for configuration options.

[sbglasius]

What a great idea 😄

[sbglasius]

Can the java-version show what distribution it comes from (Amazon, Belsoft, Oracle, etc?)

To answer myself: System.getProperty('java.vendor')

[sbglasius]

Something like this: #15230

[codeconsole]

looks nice, but I wonder I wonder if it should also display when banner is off? In all my apps, I have been using

log.info "${Metadata.current['info.app.name']}  v${Metadata.current['info.app.version']} (Java ${System.getProperty('java.version')} Groovy ${GroovySystem.getVersion()} Grails ${Metadata.current['info.app.grailsVersion']} Spring Boot ${SpringBootVersion.version} Spring ${SpringVersion.version})"

because it is useful for troubleshooting to know what versions you are running. I have banner off because I don't want to fill my logs with a banner (especially when I am running multiple instances).

Or have a separate setting to display it if banner is off?

[matrei]

looks nice, but I wonder I wonder if it should also display when banner is off? In all my apps, I have been using

log.info "${Metadata.current['info.app.name']}  v${Metadata.current['info.app.version']} (Java ${System.getProperty('java.version')} Groovy ${GroovySystem.getVersion()} Grails ${Metadata.current['info.app.grailsVersion']} Spring Boot ${SpringBootVersion.version} Spring ${SpringVersion.version})"

because it is useful for troubleshooting to know what versions you are running. I have banner off because I don't want to fill my logs with a banner (especially when I am running multiple instances).

Or have a separate setting to display it if banner is off?

@codeconsole See updated PR description, will this accommodate your use case?

[codeconsole]

@codeconsole See updated PR description, will this accommodate your use case?

yes 😄

[codeconsole]

@matrei bonus points if we can get Spring Security in there?

Class.forName('org.springframework.security.core.SpringSecurityCoreVersion')?.version

[sbglasius]

Awesome!

[matrei]

bonus points if we can get Spring Security in there?

Class.forName('org.springframework.security.core.SpringSecurityCoreVersion')?.version

@codeconsole I'm not sure we should do class loading for optional dependencies in the banner. You could add it yourself in your app:

    static void main(String[] args) {
        new GrailsApp(Application).tap {
            banner = new GrailsBanner() {
                @Override
                Map<String, String> createBannerVersions(Environment environment) {
                    super.createBannerVersions(environment) +
                        ['Spring Security': Class.forName('org.springframework.security.core.SpringSecurityCoreVersion')?.version]
                }
            }
        }.run()
    }

[jdaugherty]

I love the idea of this, but can we add documentation for this behavior? I think most of that documentation is already in this PR description - it just needs added to the docs

[codeconsole]

@codeconsole I'm not sure we should do class loading for optional dependencies in the banner. You could add it yourself in your app

I agree for any other optional dependencies, but Spring Security is such a fundamental core dependency that it would be nice to display as a default. You can just surround it with an ignored ClassNotFoundException and it is harmless.

[sbglasius]

@matrei Since SpringSecurityCore is under Apache Grails, I agree with @codeconsole, but in any other case I would disagree too.

Now that this is an open issue, how about creating a META-INF/service/grails.banner.loader with the name of the GrailsBanner class implemented, and then (I assume) SpringSecurityCore could extend GrailsBanner and override META-INFO/service/grails.banner.loader I'm not 100% sure about the load order in such case? and perhaps it's just a big overkill 😀

[matrei]

I love the idea of this, but can we add documentation for this behavior? I think most of that documentation is already in this PR description - it just needs added to the docs

@jdaugherty The functionality is now documented, thanks for reminding me!

[matrei]

@codeconsole and @sbglasius
I have added support for optional dependency versions via configuration:

grails:
  banner:
    versions:
      include:
        - spring-security
        - tomcat
        - jetty
        - undertow

[sbglasius]

Marvelous