Skip to content

Fix flaky PerTestRecordingSpec #15242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+4 −8
Merged

Fix flaky PerTestRecordingSpec #15242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ...-test-examples/geb/src/integration-test/groovy/org/demo/spock/PerTestRecordingSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

package org.demo.spock

import java.nio.file.Files

import spock.lang.Stepwise

import grails.plugin.geb.ContainerGebSpec
Expand All @@ -43,9 +45,6 @@ class PerTestRecordingSpec extends ContainerGebSpec {
when: 'visiting another page than the previous test'
to(UploadPage)

and: 'pausing to ensure the recorded file size is different'
Thread.sleep(1000)

then: 'the page loads correctly'
title == 'Upload Test'
}
Expand Down Expand Up @@ -86,15 +85,12 @@ class PerTestRecordingSpec extends ContainerGebSpec {
recordingFiles != null
recordingFiles.length >= 2 // At least 2 files for the first two test methods

and: 'the recording files should have different content (different sizes)'
and: 'the recording files should have different content'
// Sort by last modified time to get the most recent files
def sortedFiles = recordingFiles.sort { it.lastModified() }
def secondLastFile = sortedFiles[sortedFiles.length - 2]
def lastFile = sortedFiles[sortedFiles.length - 1]

// Files should have different sizes (allowing for small variations due to timing)
long sizeDifference = Math.abs(lastFile.length() - secondLastFile.length())
sizeDifference > 1000 // Expect at least 1KB difference
Files.mismatch(lastFile.toPath(), secondLastFile.toPath()) != -1
}

private static boolean isVideoFile(File file) {
Expand Down
Loading