GRAILS-10335 - Override Grails mappings for collections when property is mapped with a custom Hibernate UserType #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is mapped with a custom Hibernate UserType
Contributor
Author
|
If the pull request is accepted it should be applied to 2.2.x, 2.2.3 and master but I'm not really sure if I have to cherry-pick the commit into those branches and create new pull requests or a grails team member will do it. Please let me know what I have to do. Regards, Iván. |
Contributor
|
@lmivan Yes, if the patch is accepted into the 2.1.x branch, it will be merged into the 2.2.x branch and master by the core team (master is currently for 2.3). You will not need to open additional pull requests. |
Contributor
|
I haven't looked at the patch but the likelihood is that this will end up on 2.2.x and the master branch, not 2.1.x. There are currently no plans to release another 2.1.x version. Can you send the pull request to 2.2.x? Thanks for the help. |
Contributor
Author
|
Ohh, so there is no 2.1.6 release? :-( I've just sent a new pull-request to 2.2.x #388 Thanks and regards, Iván. |
Contributor
Author
|
I close this PR becasue #388 has been merged in 2.2.x Thanks! |
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Jan 15, 2025
* Improve release-drafter configuration * Add `pull_request` event is required only for autolabeler * Add `pull_request_target` event is required for autolabeler to support PRs from forks
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Jun 28, 2025
* Add grails-app/conf/spring/resources.groovy as a default feature (apache#366) * Add grails-app/conf/spring/resources.groovy as a default feature to align with pre Grails 6 versions * Set "executable" flag on grailsw * Update to grails wrapper 4.0.1 - includes update-wrapper command for Grails 6 (apache#375) * prep for grails 6.2.1 release (apache#376) * [skip ci] Release v6.2.1 * chore: Bump version to 6.2.2-SNAPSHOT * update grails-core to 6.2.2-SNAPSHOT (apache#379) * update grails-core 6.2.2-SNAPSHOT * Use Java 11 in 6.2.x branch (apache#382) * ci: Use Java 11 in 6.2.x branch If native image is built with Java 17, application created with it will not be compatible with Java 11. Error: LinkageError occurred while loading main class g621app.Application java.lang.UnsupportedClassVersionError: g621app/Application has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 * ci: graalvm +version -distribution Test tip from graalvm/setup-graalvm#105 (comment) * ci: Disable OSX Arm Native CLI Graalvm cannot build Java 11 OSX Arm Native Image Error: Failed to download graalvm-ce-java11-darwin-aarch64-22.3.3. Are you sure version: '22.3.3' and java-version: '11' are correct? * Include Geb/Selenium dependencies for MacOS Arch64 (apache#385) * fix: Enable inclusion of Geb/Selenium deps for Macos Arch64 This was already enabled in another part of the code in ad660a5 It looks like this was missed. * test: Temporarily disable integrationTest task in create-app specs Due to an issue with the integrationTest task during the create-app tests, the task is being temporarily disabled. The tests fail with `org.openqa.selenium.SessionNotCreatedException`, which seems to be related to the inclusion of Geb/Selenium dependencies for `OperatingSystem.MACOS_ARCH64`. The apps in the create-app tests are created with `OperatingSystem.MACOS_ARCH64` as the operating system parameter, but will fail also for other operating systems. This issue was likely masked before commit 8675723e62df6d136d7af48d5c75d7728cbef871, when the Geb/Selenium dependencies were not included for MACOS_ARCH64. With the dependencies now included, the integrationTest task fails. --------- Co-authored-by: Scott Murphy <scott@alwaysvip.com> Co-authored-by: grails-build <grails-build@users.noreply.github.com> Co-authored-by: Mattias Reichel <mattias.reichel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of GRAILS-10335. If the property in a domain class has a custom Hibernate UserType, then the UserType is responsible for mapping this column to the database and overrides Grails mapping of Map, List, Set and Bag types.
With this patch it's possible (for example) to map Map<String, String> to a Postgresql native Hstore column type instead of the additional table created by default by Grails.