GRAILS-11333: Handle already absolute URLs #504
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Where is absoluteUrlPattern defined?
Contributor
Author
|
It's there... I just did a couple pushes as I noticed my pull didn't cleanly apply against current master, so I rebased it and screwed up. Is current master compiling? I can't get it to do so using "gradlew test" even without my change. It's failing in "grails-bootstrap" with: org.codehaus.groovy.grails.resolve.PluginInstallEngineSpec > update existing metadata FAILED
groovy.lang.MissingMethodException at PluginInstallEngineSpec.groovy:18
org.codehaus.groovy.grails.resolve.PluginInstallEngineSpec > persist to metadata when plugin defined in neither metadata nor BuildConfig FAILED
groovy.lang.MissingMethodException at PluginInstallEngineSpec.groovy:31
org.codehaus.groovy.grails.resolve.PluginInstallEngineSpec > do not persist to metadata when a transitive dependency exports the plugin FAILED
groovy.lang.MissingMethodException at PluginInstallEngineSpec.groovy:43
org.codehaus.groovy.grails.resolve.PluginInstallEngineSpec > persist to metadata when transitive dependency does not export the plugin FAILED
groovy.lang.MissingMethodException at PluginInstallEngineSpec.groovy:55
org.codehaus.groovy.grails.resolve.PluginInstallEngineSpec > never persist to metadata when plugin is a non transitive dependency FAILED
groovy.lang.MissingMethodException at PluginInstallEngineSpec.groovy:67
groovy.lang.MissingMethodException at PluginInstallEngineSpec.groovy:67
|
Contributor
|
Current master is in flux whilst we go through some heavy refactoring for Grails 3.0, it will be a while before we get the tests passing again |
Contributor
|
You should send your pull request against the 2.4.x branch, which is more stable and for the 2.4.x line |
When a "uri" is provided to the link method and the "absolute" parameter is true, check if the provided uri is already absolute before trying to make it absolute.
Contributor
Author
|
Okay - I've submitted a new pull request against 2.4.x: /pull/506 |
jdaugherty
pushed a commit
that referenced
this pull request
Apr 17, 2025
* fixed broken links in quick reference * rollback unnecessary changes * rollback unnecessary changes - part 2 * rollback unnecessary changes - part 3
jdaugherty
pushed a commit
that referenced
this pull request
Apr 17, 2025
* chore(build): Modernise and clean up build - Implement buildSrc to isolate build related code and deps - Rename gradle plugin project dir to gradle-plugin - Add gradle dir for version catalogs - Implement version catalogs to handle versions - Remove redundant gradle files from subprojects - Move grailsCentralPublishing.gradle to gradle dir - Use project.layout to reference files and dirs - Make build more type-safe with IDE code completion - Unify quote usage - Clean up dependencies and tighten their scopes - Use lazy configuration where possible - Remove unused ext properties - Create workarounds for grails-gradle-plugin exposing groovy - Remove used resources and attribute to asciidoctor task - Fix classpath issues with groovydoc task - Change 'docs' task as there is nothing to copy - Change jar manifest to reflect projects properties - Remove redundant Application.groovy from views-markup - Update example projects - Add missing CompileStatic and make compatible with Groovy 3.0.21-SNAPSHOT * fix(build): Move Snapshot repos to the right place The snapshot repositories had accidentally been placed outside the configuration of the PublishingExtension. * build(chore): Clean up secret passing from GH action By using the ORG_GRADLE_PROJECT_** env vars build files can be cleaned up from checking at multiple places for the values. * ci: Replace Java 14 with Java 17 in build matrix * build: Declare grailsVersion in one place With this change the Grails version is only declared once. * build: Update Groovy Joint workflow The groovy version was not resolved correctly previously. With this change it gets set as three different environment vars. CI_GROOVY_VERSION and GROOVY_VERSION as regular environment vars and with ORG_GRADLE_PROJECT_groovyVersion that sets the groovyVersion project property. This allows for some choices in how to handle this in the build script. This change also adds a section to the settings.gradle file to allow for overriding the groovy version in the version catalog with the GROOVY_VERSION env variable. * build: Create configuration for Groovydoc The Groovydoc Gradle task need to be run with the same groovy version as Gradle. * build: Change workflow JDK to temurin AdoptOpenJDK got moved to Eclipe Temurin and won't be updated anymore. * build: Cleanup handling of sonatype credentials With this change there is no need to check both environment variables and project properties. Also move the sonatype repo info to a project property. * chore(deps): Update grails-gradle-plugin to 6.1.2 * chore(deps): Update grails to 6.1.2 * build: Make groovy workflow version independent With this change the workflow will use the versions of groovy and gradle enterprise that are defined in the build rather than hard-coding them in the actions file. * build: Minor cleanups * ci: Remove publishing of test reports These can now be viewed in build scans. * build: Remove unused import * ci: Remove java version matrix for release No need to run this on multiple versions * build: Change author and git email Puneet has a new email
jdaugherty
pushed a commit
that referenced
this pull request
Apr 17, 2025
Update to grails-core:6.2.1-SNAPSHOT
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Jun 28, 2025
Added integration-test exclusions to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a "uri" is provided to the link method and the "absolute" parameter is true, check if the provided uri is already absolute before trying to make it absolute.
I've incorporated the feedback from /pull/490 which was to use a regular expression instead of java.net.URI to improve performance.