Add cglib dependency to the Grails project test scope

[candrews]

This change addresses https://jira.grails.org/browse/GRAILS-11535

I tested this change by creating a new grails project. I ran "grails dependency-report". Then I made this change and ran "grails dependency-report" again. The only difference was the addition of these lines to the "test" scope:

+--- cglib:cglib:2.2.2
|    \--- asm:asm:3.3.1

[lhotari]

Thanks @candrews ,
I think we should use the cglib:cglib-nodep dependency since it has a shadowed/jarjar version of asm included with it. I've seen cglib:cglib cause problems .

[candrews]

I used cglib:cglib because that's what's used in build.gradle: https://github.com/grails/grails-core/blob/v2.4.3/build.gradle#L200

I've updated the PR to use cglib:cglib-nodep - should we make the same change to build.gradle?

[jeffscottbrown]

I think that this change adds the dependency to the test runtime but does not add the dependency to the build so the dependency isn't going to be in the distribution. Am I wrong about that?

[candrews]

@jeffbrown I tried it using a Grails project (see my earlier comment at #547 (comment) ) - it adds the dependency to the test scope of the project, which seems correct. Please feel free to try it as I did, of course - if there's something wrong, I'll be happy to address it.

[jeffscottbrown]

I don't think the cglib jar is being addd to the distribution. That is what I am asking about. I think that if the user doesn't happen to already have the dependency in their local cache it will have to be downloaded at test time. In general we ship dependencies with the distribution so that doesn't have to happen.

[jeffscottbrown]

I will add it to the distribution. Not a big deal.

Thanks again for the help.

[candrews]

Thanks @jeffbrown - I'm sorry I didn't know about the distribution part.