Grails-156: Update to Grails Redis Plugin to be compatible with Grails 7.x.x #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re passing. Add back some test that were previously ignored.
…he version of the plugin.
…he version of the plugin.
…he version of the plugin.
…he version of the plugin.
…he version of the plugin.
…he version of the plugin.
…he version of the plugin.
…he version of the plugin.
Grails 156
Contributor
Author
|
@jamesfredley Can you please review |
amondel2
commented
Oct 17, 2024
amondel2
commented
Oct 17, 2024
amondel2
commented
Oct 17, 2024
amondel2
commented
Oct 17, 2024
amondel2
commented
Oct 17, 2024
examples/redis-demo/src/test/groovy/com/example/MemoizeAnnotationSpec.groovy
Show resolved
Hide resolved
amondel2
commented
Oct 17, 2024
amondel2
commented
Oct 17, 2024
amondel2
commented
Oct 17, 2024
jamesfredley
requested changes
Oct 17, 2024
Contributor
jamesfredley
left a comment
jamesfredley
left a comment
There was a problem hiding this comment.
Overall it looks good. Just a few changes in comments.
* grails-156: Update H2 version to latest * grails-156: Fix Comments from Code Review
jamesfredley
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to JDK 17
Update to Grails 7.0.0-SNAPSHOT
Update to Groovy 4
Update gradle to 8.10.2
Update to use Gradle.settings for dependencies
Update to use DEVELOCITY and new Grails Publishing (Please verify I did this correctly)
Fixed some ignored test
Refactored the example program to create item in a transactional service
Refactored the example program to use LocalDate over Date