HDDS-2675. Sonar : fix issues in PipelineStateManager#347
Merged
bharatviswa504 merged 2 commits intoapache:masterfrom Dec 14, 2019
Merged
HDDS-2675. Sonar : fix issues in PipelineStateManager#347bharatviswa504 merged 2 commits intoapache:masterfrom
bharatviswa504 merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Dec 12, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @supratimdeka for fixing these issues. LGTM, except unused imports reported by checkstyle.
Contributor
|
Thank You @supratimdeka for the contribution and @adoroszlai for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Resolved all Sonar "code smell" category issues in PipelineStateManager.java, including removal of unused parameter 'conf' from the constructor.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2675
How was this patch tested?
existing junits:
TestRatisPipelineProvider.java
TestPipelineStateManager.java