Skip to content

Comments

HDDS-2725. start/_index.md translated to Chinese#397

Merged
xiaoyuyao merged 3 commits intoapache:masterfrom
iamabug:HDDS-2725
Jan 7, 2020
Merged

HDDS-2725. start/_index.md translated to Chinese#397
xiaoyuyao merged 3 commits intoapache:masterfrom
iamabug:HDDS-2725

Conversation

@iamabug
Copy link
Contributor

@iamabug iamabug commented Dec 27, 2019

What changes were proposed in this pull request?

start/_index.md translated to Chinese

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2725

How was this patch tested?

hugo server -D

@iamabug
Copy link
Contributor Author

iamabug commented Dec 27, 2019

@timmylicheng @cxorm @xiaoyuyao Please help review if you are available, thanks. PS: Are there more contributors who speak Chinese ?

@cxorm
Copy link
Member

cxorm commented Dec 28, 2019

Thanks @iamabug for the PR.
Would you edit the title of this PR ?
For translation, overall LGTM, one suggestions be inline.


你可以通过 Docker Hub 来试用 Ozone,无需下载官方发行包,这让探索 Ozone 十分容易。
<br />
{{<card title="在单个容器中启动 ozone" link="start/StartFromDockerHub.zh.md" link-text="Ozone In Docker" image="start/docker.png">}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单个容器=》Docker

{{</card>}}

{{<card title="在本地节点运行 Ozone 集群" link="start/RunningViaDocker.zh.md" link-text="docker-compose" image="start/docker.png">}}
我们也可以使用官方发行包中的 docker 文件运行 Ozone,这些文件不依赖 Docker Hub。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们也可以使用官方发行包中的 docker 文件运行 Ozone,这些文件不依赖 Docker Hub。=》
Ozone发行版包括一系列的本地docker配置文件,它们可以不依赖Docker Hub运行。

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iamabug for the patch. It LGTM overall, a few suggested edits commented inline.

Also, please check the acceptance test see if the failure is related.

@iamabug iamabug changed the title start/_index.md translated to Chinese HDDS-2725. start/_index.md translated to Chinese Jan 7, 2020
@iamabug
Copy link
Contributor Author

iamabug commented Jan 7, 2020

Thanks for the suggestions @cxorm @xiaoyuyao , they have been applied in the newest commit.

@xiaoyuyao
Copy link
Contributor

Thanks @iamabug for the update. Latest change LGTM, +1. I will merge it shortly.

@xiaoyuyao xiaoyuyao merged commit 0a3f0f8 into apache:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants