Skip to content

Conversation

@iamabug
Copy link
Contributor

@iamabug iamabug commented Apr 7, 2020

What changes were proposed in this pull request?

doc

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2800

How was this patch tested?

hugo server -D


测试工具:

* **freon** - 运行 Ozone 负责生成器。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **freon** - 运行 Ozone 负责生成器
* **freon** - 运行 Ozone 负载生成器

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it is already corrected.


管理命令:

* **admin** - Collects admin and developer related commands related to the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to translate this since I cannot use admin command in apace/ozone docker image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin commands are refactor since the last docker image. They required dev build IMHO.

I uploaded a recent build to docker hub, you can try this command with:

docker run -it elek/ozone-dev:4b1fa1099 bash
ozone admin --help

Does it help?

(Let me know if I misunderstood the problem)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what I am asking, but I cannot pull this image and I find that last image you uploaded is two months ago (https://hub.docker.com/r/elek/ozonedev/tags)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, sorry. I tried to do it in a new way with a script and didn't notice that the publish step is failed.

Should be good now (note: elek/ozone-dev, and not elek/ozonedev. It's just a sandbox, and my naming is not consistent....)

https://hub.docker.com/layers/elek/ozone-dev/4b1fa1099/images/sha256-ca96c5241cd291d8da11349632b9653cfd51ad4dc52c602062af21d8f881be0f?context=explore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek . I have tried admin command and updated the translation doc.


管理命令:

* **admin** - 供管理员和开发者使用的 Ozone 各组件管理命令。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

各组件管理命令=>管理员命令


* **admin** - 供管理员和开发者使用的 Ozone 各组件管理命令。
* **classpath** - 打印包含 Hadoop jar 包和其它必要库的 CLASSPATH。
* **dtutil** - 进行和代理 token 有关的操作。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代理 token=》token

* **dtutil** - 进行和代理 token 有关的操作。
* **envvars** - 列出 Hadoop 的环境变量。
* **getconf** - 从 Ozone 配置中读取特定配置值。
* **jmxget** - 从 NameNode 或 DataNode 中获取 JMX 导出的值。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从 NameNode 或 DataNode =》Ozone 服务

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, a few comment inline

@mukul1987 mukul1987 added the documentation Improvements or additions to documentation label May 14, 2020
@adoroszlai adoroszlai requested a review from xiaoyuyao May 27, 2020 10:24
* **scm** - 启动或停止 Storage Container Manager。
* **om** - 启动或停止 Ozone Manager。
* **datanode** - 启动或停止数据节点。
stopped.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" stopped." can be removed?

* **om** - 启动或停止 Ozone Manager。
* **datanode** - 启动或停止数据节点。
stopped.
* **s3g** -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

启动或停止s3 网关

测试工具:

* **freon** - 运行 Ozone 负载生成器。
* **genesis** - Ozone 的微型 benchmark 应用,仅供开发者使用。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove "微型"

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM, only few minor comments.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@9872253). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #780   +/-   ##
=========================================
  Coverage          ?   70.40%           
  Complexity        ?     9241           
=========================================
  Files             ?      961           
  Lines             ?    48130           
  Branches          ?     4676           
=========================================
  Hits              ?    33884           
  Misses            ?    11996           
  Partials          ?     2250           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9872253...1b64813. Read the comment docs.

@elek
Copy link
Member

elek commented Jun 22, 2020

Checked and all the suggested modification have been implemented. Merging it now as @xiaoyuyao was ok with it and the minor comments are addressed.

Thanks the patch @iamabug and the review @xiaoyuyao

@elek elek merged commit 53549ee into apache:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants