YARN-9676. Add DEBUG and TRACE level messages to AppLogAggregatorImpl… #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbacsko
requested changes
Aug 10, 2019
...che/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
Outdated
Show resolved
Hide resolved
...che/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
Outdated
Show resolved
Hide resolved
|
Hi @adamantal ! |
asfgit
pushed a commit
that referenced
this pull request
Aug 14, 2019
smengcl
pushed a commit
to smengcl/hadoop
that referenced
this pull request
Oct 8, 2019
apache#1261) * YARN-9676. Add DEBUG and TRACE level messages to AppLogAggregatorImpl and connected classes * Using {} placeholder, and increasing loglevel if log aggregation failed. (cherry picked from commit c89bdfa) Conflicts: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java - Conflicts due to YARN-8199 hasn't been backported yet. Change-Id: I01472ef4f17cf8ab6314556132ee2e9b41fc9728
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
apache#1261) * YARN-9676. Add DEBUG and TRACE level messages to AppLogAggregatorImpl and connected classes * Using {} placeholder, and increasing loglevel if log aggregation failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and connected classes
Also removed cleanupOldLogTimes and unused methods.
Looks to me that
AggregatedLogFormatandLogAggregationFileControllerhas proper logging.